Page 1 of 1

Bank

Posted: Sun Nov 08, 2020 7:44 am
by Nickrock234
Why do we have a limited amount of bank space? Is it a data storage issue or something? Serious question, please don't L&A.

Re: Bank

Posted: Sun Nov 08, 2020 7:46 am
by Monys
viewtopic.php?f=92&t=426&p=5473#p5473 -> Rapsey in 2013

viewtopic.php?f=134&t=77303&p=695573&hi ... ce#p695573 -> A more recent discussion.

The search feature is a very powerful tool.

Re: Bank

Posted: Sun Nov 08, 2020 7:57 am
by Nickrock234
In the first post it was stated to be an issue in the RAM on loading the bank. He said that it has to load the maximum amount of bank slots regardless of the total amount of slots used. Can I ask if anyone knows why that is? That was also five years ago.

Rapsey also states they store player data in a much more efficient way than traditionally done.

Re: Bank

Posted: Sun Nov 08, 2020 8:02 am
by Jon
nice

Re: Bank

Posted: Sun Nov 08, 2020 11:36 am
by Raj
I believe this quote
Due to the limitations of the engine and for performance reasons, we need to load the entire bank, regardless of how many bank spots are actually being used.
is no longer true due to progress in data structure optimization. However, as Thoby mentioned here (viewtopic.php?f=134&t=77303&p=695573#p695551), there remains an issue w.r.t displaying over 800 items. I believe there may be a very complicated fix which involves loading and freeing "chunks" (in our case, tabs) when displaying the bank GUI, but there's no need to even describe it because I believe implementing it would be absolute hell in Java. Also as Thoby mentioned, optimizing just the storage aspect is theoretically possible, but would require a rewrite of certain key portions of the code (inserting items into the bank, removing an item from the bank, etc.) which would be susceptible to bugs (in a place you generally don't want bugs).

Re: Bank

Posted: Sun Nov 08, 2020 12:31 pm
by Thoby
Raj ones again with the elaborate and accurate response. Exactly what he said.

However, without spoiling too much, I think we have managed to fix the related problems for the most part. We are currently looking into storing it efficiently on the database-side, but that's a matter of testing an optimization. Rapsey and Mike have been working on that for a little while now, so expect to see those results soon.

Re: Bank

Posted: Sun Nov 08, 2020 5:44 pm
by Brant
Thoby wrote: Sun Nov 08, 2020 12:31 pm Raj ones again with the elaborate and accurate response. Exactly what he said.

However, without spoiling too much, I think we have managed to fix the related problems for the most part. We are currently looking into storing it efficiently on the database-side, but that's a matter of testing an optimization. Rapsey and Mike have been working on that for a little while now, so expect to see those results soon.
Oh by, he said the 's' word. We know what that means gang. 1-2 years from now

Re: Bank

Posted: Sun Nov 08, 2020 5:48 pm
by Monys
Brant wrote: Sun Nov 08, 2020 5:44 pm
Thoby wrote: Sun Nov 08, 2020 12:31 pm Raj ones again with the elaborate and accurate response. Exactly what he said.

However, without spoiling too much, I think we have managed to fix the related problems for the most part. We are currently looking into storing it efficiently on the database-side, but that's a matter of testing an optimization. Rapsey and Mike have been working on that for a little while now, so expect to see those results soon.
Oh by, he said the 's' word. We know what that means gang. 1-2 years from now
Thoby wrote: Sun Nov 08, 2020 12:31 pm soon.
Image

Re: Bank

Posted: Tue Nov 10, 2020 6:10 am
by Nickrock234
Pretty much answers my question. Thank you, Raj, Thoby.