Client upgrade - bugfix progress thread

PkHonor's work in progress and future updates will be posted here.
User avatar
Mike
Programmer
Posts: 6348
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Sat Nov 12, 2016 3:54 am

11 November progress update:
Fixed some more bugs (haven't updated the list yet), including:
- Some wrong wall textures (most notable at Castle Wars). Haven't found a fix for the Castle Wars stairs in resizable/fullscreen yet (I blame Jagex for that one, anyway), but all walls, towns, roofs, ... should have the proper texture (as in OSRS)
- Fixed a fullscreen mode bug in Windows
- Fixed a glitch where your character would become invisible for a fraction of a second when you perform a special attack for the first time
- Added distant fog (actually just a different background color rather than black, added a setting for it in the Display options)
- Most of the noclipping in Player-Owned Houses. I had to make some changes to the new server-sided pathfinding methods and there is still a bug where having an object next to a wall makes the wall noclippable. I'll get around to fixing that yet but all other noclipping behavior seems to work fine.



Of course, keep in mind most of these bugfixes require a client update which will be done once most of the bugs are fixed.

User avatar
Tezey
Honor Player
Posts: 1679
Joined: Thu Jul 03, 2014 7:13 pm
Location: Sweden

Re: Client upgrade - bugfix progress thread

Post by Tezey » Sat Nov 12, 2016 2:05 pm

Is there an automatic updater yet?
Image

User avatar
Mike
Programmer
Posts: 6348
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Sun Nov 13, 2016 8:17 am

Tezey wrote:Is there an automatic updater yet?
Not yet, I'm hoping to have that included in the next testserver release within 2 weeks or so.

13 November progress update: I've managed to perfect the Player-Owned House noclipping checks! Hopefully that should be (one of) the last big/hard to fix things, now back to the bug reports :)

User avatar
Mike
Programmer
Posts: 6348
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Sun Nov 13, 2016 11:50 pm

Another 13 November progress update: I've gone through all 25 pages of bug reports on the news thread and made my final bughunter report (unless there's new reports, but there don't seem to be many the past couple of days).

I currently count 86 74 unfixed bugs (out of 155), let's see how fast we can get them down to 0 ;)
Some of them still need to be tested and may turn out to be already fixed.
Spoiler: show
Improvements (not part of bug reports or things that were already on my to-do list before the contest)
> Interaction with NPC's has been fixed (this applied to any sort of interaction, such as shopping, talking, banking through a banker, fishing, ...). There were lots of bug reports about this, but since they all have the same cause, only one player got the reward
> Fixed all glitched equipment. Since almost all bug reports related to glitched equipment had the same cause, only one player got the reward
> Noclipping checks in Player-Owned Houses have been added (they do not yet apply for NPC's, but that's not much work and will be done when I finish the rest of the new pathing)
> The algorithm for determining which coins or tickets to take from your inventory (when spending money through a shop, the GE, ...) has been improved
> All wrong textures of walls, roofs, buildings, floors, ... have been fixed (most notable was the middle area of Castle Wars, but definitely other places we hadn't tried yet)
> Your client will now remember if you maximized your client in resizable mode
> The positioning of the client on the screen has been improved in resizable mode
> You can now adjust the brightness of your client
> Fixed a glitch where the account pin interface would get closed in some special cases (preventing you from doing anything until you relog)
> You can no longer close the character creation screen when you log in for the very first time
> Fixed a bug where your character would only show a head (and nothing else) if you don't complete your character creation the first time you log in
> When changing your appearance at the make-over mage, your current appearance will be shown instead of the 'default' (typical bald) male character. Same for when making a new account.
> Added fog (actually just a different background color rather than black), can be toggled through Display settings
> Slightly improved balloon popping in the Drop Party room: instead of instantly popping a balloon, you will now perform the 'stomp' animation, then after a random delay of 0.6s - 0.9s, you'll pop the balloon. This makes drop parties slightly more fair towards players with a high ping.
> The Edgeville furnace now works


Bughunter contest reports

Factorial (no points because no in-game name stated)
> Doesn't work on Linux


Saltyy
> Glitched equipment
> 'Store X' in bank does not work (does examine instead)
X When withdrawing from Grand Exchange it is not able to give you more than 2147m. It's somehow unable to give you 1B Tickets.
- 10x damage does not work (known, not yet implemented)


Im on meth
X Resizable mode doesn't show the full client (OS X only? needs to be tested again)
> Toolbar isn't hidden in fullscreen on Mac
> Crowns in right-click when adding friends
> Cannot use the PoH portal to enter a friend's house
> Opening display options closes bank pin screen
> Picking up items off the ground doesn't remove them from the ground (visual, only applied to items with ID bigger than 32000)
> Changing modern tab area settings in Display options glitches your side panel when in fixed mode
> Logging on an account, logging off, and logging in on a new account causes friends list/ignore lists to merge for both accounts
> Cannot drop most items for other players (also applies to trading and staking)
X Doesn't say when a player logs in or out on your friends list.
X If you click on an NPC while talking to a different one, your guy will run 1 square towards the new NPC and stop.
> You're unable to walk 1 space (can't move to the 8 squares you touch). Can only move if the distance >= 2.
X You can see what players type when they're on your ignore list. It doesn't show up in the chat but still shows above their head.
X Bug: Doing an emote while ::afk causes your character to be stuck but you can sorta fake move around, moving anyone following you. If you do ::afk again then try to move, you teleport to where your fake character is.
- Modern healthbar option does not work (known, not yet implemented)
- At the ancient altar, you can only switch your spellbook to normal/ancient every couple of seconds (intended behavior, also works like this in production, to prevent accidental loss of pkpoints)


Demonwrider (Derrick46546)
> Cannot close the client except through task manager
> Vote store does not open


Slap a ho
> Cannot properly interact with any NPC's
> Brawling gloves cause invisibility (missing models)
X ::ss bugged
> Steadfast boots glitched (missing model)
> Cannot use tab to quick-reply
> Glitched marble staircase in dungeon (wrong id)
> Cannot remove NPC's from dungeon
> Glitched white tiles in the wilderness
X Cannot cut webs in wild
- Killing a monster drops all loot (intended testserver behavior)
- Noclipping inside a PoH does not work (known, not yet implemented)
- Dying in POH dungeon causes you to lose your items (intended behavior, also works like this in production. You don't lose items when PVP is enabled)
- Casting spells/attacking with ranged makes you walk all the way to the enemy (known, not yet implemented)


Matteh
> Steadfast boots glitched (missing model)
> Cannot change morph ring NPC or add charges (all 2nd click or 3rd click on items with ID > 32000 was broken)
X Randoms don't follow you and give up when you move -


Floriduh
> Cannot use gnome agility log balance
> Cannot use wildy agility area stepping stones or log balance
> When losing HP to Rogues, the HP bar always appears red. Monsters seem to be fine. Explosive potions and overloads are fine
> Duel arena settings do not show any check marks to alert players what has been selected (visual)
> Royal items are bugged
> Cannot alch most items
> You cannot interact with trees in farming patches when standing at the North or East side
> Varrock bank booths do not work
> Seers village bank booths do not work
> The body runecrafting altar does not work
X You can noclip at pest control
> The Minimap at Barrows is buggy
> If you leave a room too early during regular barrows and you do not get the kill count, you cannot re-search the sarcophagus by re-entering (needs to be tested again)
> If you have max cash in your inventory, when you attempt to withdraw coins from your bank the coins drop to the ground. The issue is instead of dropping the whole stack, it'll only put one coin on the ground.
> When you're on fullscreen and you go to bank, your inventory automatically opens if you are on a skill tab, combat tab, etc. However, if they're all minimized, you'll have the bank open with no inventory showing. It should automatically pop up (it does in OldSchool, at least)
- ::settings bugs your settings tab (new settings dialog is not yet fully implemented, command will be removed soon)


Wir3d
- Brightness adjustment does not work (known, not yet implemented)


Retsnom (Dead cats)
> 'Check steps' on any clue scroll (or WW scroll) makes you equip it
> The Grand Exchange is buggy when placing a buy offer or searching for items
> The Construction Expert is shown as 'No fingers'
> Withdrawing 'X' from refund box does examine instead
- You cannot light fires at a Player-Owned House or the skilling center (intended behavior), but you can use an inferno adze to light fires (also intended behavior). I might change this behavior, but it all works the same as on the production server, so either way no points are awarded.
- Mandrith, Nastroth and the Construction Expert chat heads show as Leprechaun (known bug, as stated on my original post)
- Boots of Darkness go to weapons slot (known, not yet implemented, we don't know yet when we'll add this)
- Type of damage is not shown on hitsplats (not yet implemented)
- No time limit between yells (intended testserver behavior)
- ::setlevel command works with hunter, construction, and summoning. Does requires 2147m (intended testserver behavior)
- Clue scrolls are not included in the 100% drop droptable (intended testserver behavior, they will only drop as often as on the production server)


Kuhana (Shadedice)
> Revenant/arrow clue scroll does not show the arrow in fullscreen/resizable
> You cannot close the revenant/arrow clue scroll interface
> Frost dragons have glitchy movement in combat (caused by an incorrect size setting)
X Can not loot Kingly Impling jars, are any other jars that contain imps or butterflies
X (maybe fixed? needs to be tested) Clan chat breaks when you relog after joining a CC (needs to be tested again though)


The builder
X Run does not turn off when depleted. It remains active and as soon as you regain a single percent, you run for a second before stopping
> pressing 'esc' doesn't clear chat on new client. Closes windows like it does on current one, but doesn't clear chat.
- You can ::copy players in the wilderness or duel arena (known, not a bug since this can only be used by honors and admins, works the same as on production)


Nerds123
X Cannot use the Tab key to switch between username/password at the login screen
X There are no magic trees at Premium skill zone.
X Dungeon entrance at ::skilling does not work (no stairs in the room below)
X You cannot walk around in the Tormented Demons area
X Black Demons don't have their Animations set correctly
X If you turn on SS using ancient curses, it actually does an animation which it shouldnt do (The character stomps the ground :o )
- Sound/chat/game options do not work (known, not yet implemented)
- Price checker interface does not work (known bug, not yet implemented)
- You can leave ::private through the double doors (a feature rather than a bug, intended behavior)


Lunar (I am mexican)
> Cannot use 'Withdraw all-but-one' in bank
X Certain monsters at godwars cannot be attacked.


Pvm keagan (Pure 2k12)
> Whenever you go to buy items from Grand exchange, constantly get the messages "you can't trade that item through grand exchange" & "The price of that item must be higher than 1/10th of the guided price"
X if you have auto retaliate on when fighting a boss and try and run away you'll be stopped and forced to run back to the bosses location.


Underlord (Ohai)
X Pickpocketing from NPC's shows a glitchy animation
X @ lumby, if I sheer a sheep while spamming other sheep, I can sheer 3 before moving the spot I'm in. On nontest it doesn't let me do that.
X When trying to buy 1 lottery ticket without any money, it says you need 40m to buy it. If you choose the 5 for 40m option without, it says you need 8m. (they're backwards)
X @ the tent when you first make an account, if you leave, stand anywhere, and then click the skilling portal, you no clip through the tent.
X When I walk through this door and shut it, I can't open it again. If I click the other door I don't even walk towards it.
X Also the user G Smokey traded me while I was like this, and he was able to trade from an unusual distance. When trying to trade him I wasn't able to trade him anything I had in my inv, idk if trading works at all or not yet.
X If you're standing through walls the trade screen is usable, he was able to give me rocktails and claws, but I was unable to trade him a cannon, or a bronze pickaxe. We recreated this many times just as it's shown in the screenshot, with both doors closed.
X After further testing Gdawg97 and I found that as long as you are standing far apart each other, and neither of you are moving at the time the trade goes through, it works without any problems.
X Also if you send a trade request, and then you both tp to the same spot, the trade works after accepting it.
- ::master updates experience in the EXP counter but not experience on the stats tab (cannot be reproduced? does not seem to be a bug?)


Sverre (ruler)
> Party balloons walk through the table (and walls)
X If you were at ::chill on the production server, you float in the air on the testserver (kinda known but had forgotten about this, I'll add a check to prevent this)
> When you wrongly put in your PIN it won't log you out but you will remain logged in and you can try again.
> There is an altar at ::private you can walk through
X Doesn't show status (premium etc) if you pm someone.
X Pming in general is glitchy. Pming someone/::m someone sometimes shows up for the other and sometimes it doesn't
X If you already had a slayer task on production, it's now bugged
X Stepping stones at werewolf agility don't work (probably stepping stones in general so also in castle wars don't work)
X There is no stick at werewolf agility course
X you can unequip mouth grip if you use the zipline at werewolf agility. You will get the item in your inventory and it will look like you run down the zipline
X There are no revenants in the wildy (not sure about this one)
X The agility option at godwars teleport doesn't work. I suppose that is the route to go to the top to the statue for Last Journey. Can't get there now.
X In godwars you can't go northeast so you can't get to the bridge to go to zamorak.
X You noclip through the objects that are at godwars (the one in the middle of the map)
X Can't operate powdered wig
X Says I don't have stairs in my dungeon in poh (but I do)
X Donator zone shows a black square on minimap
- Using a rotten tomato on the knights at ::party will spawm you with 'nothing happens' (not a bug, it also works like this on the production server - to throw them, you just need to use the 'talk-to' function with the knights)
- You can't put most items in the party chest (cause was most items being untradeable, was reported before)
- You can't pop balloon animals (known bug - you can actually pop them, but it's very hard to catch them - due to the pathing that is not yet fully implemented)
- Edgeville teleport is called pvp teleport (intended behavior)
- you always get teleported to the same height in ::private (also works like this in production, not a bug - the height depends on your pid)
- If you are in a clan nothing happens when you click on help. (not a bug, this is our 'dual cc' feature - you are actually in the help cc and your own cc at the same time - use '\' for help cc chat)
- can't change how you see your friend chat (known bug, not yet implemented)
- When you attack and get attacked it doesn't show in which style (known, not yet implemented)


Jelle (Houwuh)
X transformed players can enter the wildy.


Sverre (ruler) & Houwuh
> All objects on the first floor are misplaced (will require a new database copy on the testserver to fix)
X If you use the ladder in borks cave you end up in donator zone. Couldn't check if the same happens for normal players because you can't talk to any NPCs to remove donator/premium because interface immediately closes.
X Can't build any new room/remove rooms in poh.
X Glitchy ::height? (not sure about this one tbh)
X If you die with honor inside (explosive potions) you end up in some tower northeast of the team bases (very minor since it's on another height)
X If you click for an example the stairs in castle wars and someone places a barricade in front of the stairs before you arrive there but after you clicked on the stairs, you will walk through the barricade and go down the stairs.
X Not sure what happened but I searched for Burnt Manta Ray in grand exchange and then I couldn't search for anything else and it would say '.........rch......' (picture 1) Relogging or using another account doesn't fix it. When I tried to teleport to Houwuh it gave me this message and the client crashed (second pic). Asked Houwuh to do the same. Looking at buy offers will crash your client.
X Seems like salamanders don't work properly. USed black salamander+harralander tar in pernix and I hit 14 as max hit
- you can enter cw with honor, go on another height and just walk in (probably the same on production, but CW only works at height 0 so I don't see the problem)
- You don't get tickets for action in castle wars (opening door first time, killing people). Randomly got a ticket when I destroyed a barricade. Getting tickets is off. (probably not a bug)
- Salamander attack emote shows like melee (known bug)


Adamthalion
X Home tabs turned into varrock tabs, yet they take you to edge still.
X Cant cast crumble undead on the max hit dummies. (might also be on production)
> In between home and west varrock bank, there is something that looks like a wall that says "Search Evergreen." (wrong model)
X Can walk through obstacles at gwd.
X Teleporting at a gwd altar, brings you back to the door, but inside the chamber.
X Cant get to the zamorak bridge in gwd. Wont let me walk there.
X The rock going down to the saradomin encampment is not the right thing. It is a pile of rubble and weapons.
X All monsters bigger than 1x1 wont stay still when you are attacking them. You walk under them to attack, and they in turn back up until they are against a wall.
X My graador pet was blocking attacks from all bosses.
- Blowpipe and other zulrah items don't work as intended (known, not yet implemented)
- The "peek" options on the gwd doors do nothing atm (known, not yet implemented)


Elliott715
X The game says 3 air runes per teletab, but I made 10 teletabs and it only use 3 air runes.
X The time remaining icon in pest control is broken. The number is going down, but the 500 is on top of it so you cannot see the time you have left


Horor donkey
X cannot climb up a rope at KQ
X Destroying ancient book will drop it on the ground (actually also works like this on the production server, but I've fixed it & granted points anyway)
X When using rotten tomato on white knights "nothing interesting happens" will spam in chat
- Salve amulet e will save you if you die in wildy by WW or KBD (intended behavior, its only when you die in PvP that it won't save you)
- there are no rev dragons in KBD's lair (no bug, they spawn at random)


Malthazare
X Auto Retaliate pathing is a little buggy when you're being attacked by multiple enemies. Your character almost gets pulled around (sometimes in random directions?) I noticed it most in boss rooms with multiple enemies (such as nex, and other GWD).


Tigerlithe & Gdawg97
X Morph world wilderness. It is possible to go to wilderness in morph world. Both accounts teleported to morph world and after that both crossed the ditch to wilderness. Account seen on the left side walked all the way for edge to kbd and account on the right side teleported to kbd.


Pf13 (no points because no in-game name stated) & Gdawg97
X When morphed (as a death) and running it still does the walking animation, just faster.
X Minor bug but rather still report it, teled to Morph Realm at the ge area and the bankers disappeared.
X When dueling, you're unable to forfeit the duel.


Skullsnipe
X Teleporting to staff height or morph realm while in the corp caves just teleports you into oblivion (no points because no in-game name stated)


Astronomical
X If you cast a spell and use the minimap to move away, then you can continue casting a spell from anywhere that is in range. Even from behind other objects.


Godfather44 (Godfather4)
X Elegant Items are put in weapon slot and overlap with the items wielded. For example: golden elegant blouse replaces your weapon and overlaps with the platebody you wear
X Torva doesn't provide the intended health bonus when eating or healing with Tentacle of Souls
X Whenever i copy a bank with a honor player, the whole bank is gone when i close and restart the client (look into this, might also be a bug on production server, idk)


Kittenlord
X i have found that the jungle impling area has a huge black area that cannot be walked on.
X most of the implings are stagnant.
X Woodcutting level up shows a stick instead of the tree symbol in the chat box.
X there is now a bank chest next to the booth in the crafting guild, and it is not accessible (was a known bug, bank hasn't been moved to the chest yet, but had forgotten about it)


No pity (no points because no in-game name stated)
X spiders are unagressive at monkey guards
X Nex has lower accuracy?
> Ruby Bolt (e) specs causes player to disappear sometimes (actually applied to all special effects when shown for the first time)
- All Dagannoth Kings are agressive regardless of distance (doesn't seem like a bug to me)


Chlor (no points because no in-game name stated)
X idk if this is just me but my pet isn't showing up, it's not in bank, and it's not in refund.
X When buying donator points from vote shop, is declares, "You have bought 100 donator credits for 0 vote points, you now have 100 credits." no matter how many times you have bought.


Counterret
X casting teleports from the ancient spell book drags your gear out of their format
X Casting barrage also drags your gear out of his format ( maybe this is with everything on the ancient spellbook? )


Dragon mann
X at risky barrows u dont need a dwarf multicannon to start and there's no ahrim at lol
X at godwars dungeon at bandos u need to kill 80 one to get 40 kc so u need to kill 2 goblins to get 1 kc


Marinclaric
> Found a Money Duping Bug. If you have max cash in bank and have cash in inventory. When you withdraw max cash the pile you leave on the ground becomes an endless money pit. I could just run to get a 1b ticket then get more cash from the pile on the ground and do it over and over. I had fun getting a nice pile of 1b tickets.

[Edit] 74 left to go

User avatar
Mike
Programmer
Posts: 6348
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Tue Nov 15, 2016 2:38 pm

About 60 more bugs to fix. Also implemented some missing features like 10x damage (visual only) and modern & oldschool hitsplats (I've thrown out the 562 hitsplats previously coded in).

Also, small preview of what this fog looks like:
Image

Srczm
Premium Donator
Posts: 32
Joined: Mon Sep 23, 2013 4:37 pm

Re: Client upgrade - bugfix progress thread

Post by Srczm » Tue Nov 15, 2016 8:33 pm

cant u put osrs bug slpats in.?

User avatar
Mike
Programmer
Posts: 6348
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Wed Nov 16, 2016 8:31 pm

Srczm wrote:cant u put osrs bug slpats in.?
If you mean hitsplats, then yes, that's available through the Display options ;) they look the same as our current oldschool-style hitsplats in PkHonor.

16 November progress update: only 40 more bugs to go!

User avatar
Skullsnipe
Premium Donator
Posts: 1353
Joined: Sat Apr 13, 2013 3:10 am
Location: Rapsey's Basement

Re: Client upgrade - bugfix progress thread

Post by Skullsnipe » Wed Nov 16, 2016 10:50 pm

Will the client have it's full release after you're finished fixing those bugs? Or is that just the end of the bug hunter contest?
Image

Srczm
Premium Donator
Posts: 32
Joined: Mon Sep 23, 2013 4:37 pm

Re: Client upgrade - bugfix progress thread

Post by Srczm » Thu Nov 17, 2016 1:00 am

yeh sorry hit splats ahha cool cool

User avatar
Ruler
Honor Player
Posts: 7541
Joined: Mon Nov 11, 2013 6:13 pm
Location: The Netherlands

Re: Client upgrade - bugfix progress thread

Post by Ruler » Thu Nov 17, 2016 1:07 am

Skullsnipe wrote:Will the client have it's full release after you're finished fixing those bugs? Or is that just the end of the bug hunter contest?
I hope he will release a final test client. Much easier to find more glitches if all other ones are fixed.

Locked